Ticket #60 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

AK_FRAMEWORK_DIR is not 'DRY'

Reported by: bobchin Assigned to:
Priority: minor Milestone: 0.8
Component: Scripts Keywords:
Cc:

Description (Last modified by bermi)

after setup, constant 'AK_FRAMEWORK_DIR' is defined two places. (public/index.php and config/config.php) I think this is not 'DRY'.

I guess this is because considering for framework_setup_controller on script/setup command. I have alternatives.upload three patches.

Attachments

script.setup.patch (0.8 kB) - added by bobchin on 09/09/07 23:52:59.
public.index.php.patch (426 bytes) - added by bobchin on 09/09/07 23:53:13.
app.controller.framework_setup_controller.php.patch (0.7 kB) - added by bobchin on 09/09/07 23:53:24.

Change History

09/09/07 23:52:59 changed by bobchin

  • attachment script.setup.patch added.

09/09/07 23:53:13 changed by bobchin

  • attachment public.index.php.patch added.

09/09/07 23:53:24 changed by bobchin

  • attachment app.controller.framework_setup_controller.php.patch added.

09/14/07 17:07:57 changed by bermi

  • status changed from new to closed.
  • resolution set to fixed.
  • description changed.

bobchin, thanks for the patches. I've committed the changes on [359].

It would be helpful to have unified patches instead of one patch per affected fle.

You can do this with svn diff > bug_description.patch