Changeset 252

Timestamp:

06/07/07 08:15:35 (1 year ago)

Author:

bermiferrer

Message:

Performance improvements.

Preventing attribute composing on models without any attribute composing settings.

Adding the possibility of disabling name-based setters/getters like setName which will be triggered by set('name',...).
This is the default value for now, but might change in a future release as it can lead to confusion.

Added also some performance comments to config/production.php

Files:

• trunk/config/development.php (modified) (1 diff)
• trunk/config/production.php (modified) (1 diff)
• trunk/config/testing.php (modified) (1 diff)
• trunk/lib/AkActiveRecord.php (modified) (11 diffs)
• trunk/test/fixtures/config/config.php (modified) (1 diff)

trunk/config/development.php

@@ -2 +2 @@
-
-// Define constants that are used only on a development environment
-available_constants
+boot
-
-define('AK_ENABLE_STRICT_XHTML_VALIDATION', false); // At least until the validator is fully tested

trunk/config/production.php

@@ -2 +2 @@
-
-// Define constants that are used only on a production environment
-available_constants
+boot
-
+/**
+ * Performance tricks for production environments.
+ * 
+ * Disable callback getters/setters. If you allways use 
+ * AkActiveRecord::get('attribute_name') and AkActiveRecord::set('attribute_name', $value)
+ * instead of AkActiveRecord::getAttributeName and AkActiveRecord::setAttributeName
+ * you might want to disable thath functionality by uncommenting the next two line.
+ */
+// ak_define('ACTIVE_RECORD_ENABLE_CALLBACK_SETTERS', false); 
+// ak_define('ACTIVE_RECORD_ENABLE_CALLBACK_GETTERS', false); 
+
+/**
+ * These settings can also help on heavy load sites, but please TEST that these new defaults
+ * don't break you working application.
+ * 
+ * DONT CHANGE ANYTHING IF YOU DON'T KNOW WHAT IT MEANS.
+ */
+// ak_define('ACTIVE_RECORD_VALIDATE_TABLE_NAMES', false);
+// ak_define('ACTIVE_RECORD_SKIP_SETTING_ACTIVE_RECORD_DEFAULTS', true);
+// ak_define('ACTIVE_RECORD_ENABLE_PERSISTENCE', true);
+// ak_define('ACTIVE_RECORD_CACHE_DATABASE_SCHEMA', true);
+// ak_define('ACTIVE_RECORD_CACHE_DATABASE_SCHEMA_LIFE', 86400);
-
-?>

trunk/config/testing.php

@@ -2 +2 @@
-
-// Define constants that are used only on a testing environment
-available_constants
+boot
-
-

trunk/lib/AkActiveRecord.php

@@ -20 +20 @@
-require_once(AK_LIB_DIR.DS.'AkActiveRecord'.DS.'AkAssociatedActiveRecord.php');
-
+// Use setColumnName if available when using set('column_name', $value);
+ak_define('ACTIVE_RECORD_ENABLE_CALLBACK_SETTERS', true); 
+ak_define('ACTIVE_RECORD_ENABLE_CALLBACK_GETTERS', true); 
-ak_define('ACTIVE_RECORD_ENABLE_PERSISTENCE', AK_ENVIRONMENT != 'testing');
-ak_define('ACTIVE_RECORD_CACHE_DATABASE_SCHEMA', AK_ACTIVE_RECORD_ENABLE_PERSISTENCE && AK_ENVIRONMENT != 'development');
+ak_define('ACTIVE_RECORD_CACHE_DATABASE_SCHEMA_LIFE', 300);
-ak_define('ACTIVE_RECORD_VALIDATE_TABLE_NAMES', true);
-ak_define('ACTIVE_RECORD_SKIP_SETTING_ACTIVE_RECORD_DEFAULTS', false);
@@ -1560 +1564 @@
-
-
-
-
+
-        static $watchdog;
-
@@ -1573 +1576 @@
-
-        if($inspect_for_callback_child_method === true && method_exists($this,'set'.AkInflector::camelize($attribute))){
+            static $watchdog;
-            $watchdog[$attribute] = @$watchdog[$attribute]+1;
-            if($watchdog[$attribute] == 5000){
@@ -1586 +1590 @@
-            $this->{$attribute.'_before_type_cast'} = $value;
-            $this->$attribute = $value;
-
+empty($this->_combinedAttributes) && !
-                $combined_attributes = $this->_getCombinedAttributesWhereThisAttributeIsUsed($attribute);
-                foreach ($combined_attributes as $combined_attribute){
@@ -1622 +1626 @@
-    }
-
-
-
-
-
+
+
-        if($attribute[0] == '_'){
-            return false;
@@ -1631 +1633 @@
-
-        if($inspect_for_callback_child_method === true && method_exists($this,'get'.AkInflector::camelize($attribute))){
+            static $watchdog;
-            $watchdog[@$attribute] = @$watchdog[$attribute]+1;
-            if($watchdog[$attribute] == 66){
@@ -1643 +1646 @@
-        if(isset($this->$attribute) || (!isset($this->$attribute) && $this->isCombinedAttribute($attribute))){
-            if($this->hasAttribute($attribute)){
-
+!empty($this->_combinedAttributes) && 
-                    $this->composeCombinedAttribute($attribute);
-                }
@@ -1850 +1853 @@
-        }
-    }
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
-    function composeCombinedAttribute($combined_attribute)
-    {
@@ -2559 +2549 @@
-        if(AK_ACTIVE_RECORD_CACHE_DATABASE_SCHEMA && AK_CACHE_HANDLER > 0){
-            $Cache =& Ak::cache();
-300
+AK_ACTIVE_RECORD_CACHE_DATABASE_SCHEMA_LIFE
-            $Cache->clean('AkActiveRecord');
-        }
@@ -2568 +2558 @@
-        if(isset($_SESSION['__activeRecordColumnsSettingsCache'])){
-            $Cache =& Ak::cache();
-300
+AK_ACTIVE_RECORD_CACHE_DATABASE_SCHEMA_LIFE
-            $Cache->save(serialize($_SESSION['__activeRecordColumnsSettingsCache']), 'active_record_db_cache', 'AkActiveRecord');
-        }
@@ -2577 +2567 @@
-        if(!isset($_SESSION['__activeRecordColumnsSettingsCache'])){
-            $Cache =& Ak::cache();
-300
+AK_ACTIVE_RECORD_CACHE_DATABASE_SCHEMA_LIFE
-            if($serialized_column_settings = $Cache->get('active_record_db_cache', 'AkActiveRecord') && !empty($serialized_column_settings)){
-                $_SESSION['__activeRecordColumnsSettingsCache'] = @unserialize($serialized_column_settings);

trunk/test/fixtures/config/config.php

@@ -19 +19 @@
-define('AK_SITE_URL_SUFFIX', str_replace(array(join(DIRECTORY_SEPARATOR,array_diff((array)@explode(DIRECTORY_SEPARATOR,AK_TEST_DIR),
-(array)@explode('/',@$_SERVER['REQUEST_URI']))),DIRECTORY_SEPARATOR),array('','/'),AK_TEST_DIR));
+
-
-//define('AK_SKIP_DB_CONNECTION',isset($db) && $db === false);